Conversation
lcovar
force-pushed
the
BTC-2927
branch
2 times, most recently
from
38f8699 to
859b256
Compare
OttoAllmendinger
requested changes
Jan 14, 2026
Contributor
OttoAllmendinger
left a comment
OttoAllmendinger
left a comment
There was a problem hiding this comment.
actually you need to include the package in the github action test matrix
OttoAllmendinger
requested changes
Jan 14, 2026
Comment on lines
2
to
5
| "name": "@bitgo/wasm-solana", | ||
| "description": "WebAssembly wrapper for Solana cryptographic operations", | ||
| "version": "0.0.1", | ||
| "type": "module", |
Contributor
There was a problem hiding this comment.
you have to set this to private: true for now, otherwise we'll break the publish action
Implement wasm-solana package for Solana address generation using official Solana SDK crates (solana-pubkey, solana-keypair) compiled to WebAssembly. This is Phase 1 of replacing JavaScript Solana dependencies to mitigate npm supply chain attack risks. Architecture follows wasm-utxo patterns: - Core types wrap official Solana SDK with extension traits (PubkeyExt, KeypairExt) - Thin WASM bindings (src/wasm/*.rs) expose types to JavaScript - TypeScript wrappers (js/*.ts) provide idiomatic camelCase APIs Components: - Pubkey: base58 encoding/decoding, is_on_curve() for PDA detection - Keypair: creation from 32-byte seed or 64-byte Solana secret key format Build tooling: - Makefile matching wasm-utxo's wasm-pack workflow - TypeScript configs for ESM and CJS output Verified compatibility with BitGoJS sdk-coin-sol test vectors. Ticket: BTC-2927
OttoAllmendinger
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the initial wasm-solana package to support Solana address generation using Rust compiled to WebAssembly. This is the first phase of replacing JavaScript Solana dependencies (@solana/web3.js, tweetnacl) with secure Rust implementations to mitigate npm supply chain attack risks.
Architecture follows wasm-utxo patterns:
Components added:
Build tooling:
Verified compatibility with BitGoJS sdk-coin-sol test vectors to ensure byte-identical address derivation from the same secret keys.
Ticket: BTC-2927